Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Use preBuildMenu instead of pimcoreReady #14

Closed
martineiber opened this issue May 31, 2023 · 3 comments
Closed

[Bug]: Use preBuildMenu instead of pimcoreReady #14

martineiber opened this issue May 31, 2023 · 3 comments
Assignees
@aryaantony92
Labels
Bug
Milestone
v2.0.1

Comments

@martineiber
Copy link
Contributor

Expected behavior

preBuildMenu should be used in the startup.js

Actual behavior

It still uses the old pimcoreReady function.

Steps to reproduce

Generate a new bundle and check the startup.js
@martineiber martineiber added this to the v2.0.1 milestone May 31, 2023
@martineiber martineiber self-assigned this May 31, 2023
@dvesh3 dvesh3 assigned aryaantony92 and unassigned martineiber Jun 28, 2023
@aryaantony92 aryaantony92 mentioned this issue Jun 29, 2023
Merged
@kingjia90
Copy link
Contributor

Resolved by #15

@dvesh3 dvesh3 reopened this Jul 4, 2023
@dvesh3
Copy link
Contributor

dvesh3 commented Jul 4, 2023

we should add not remove pimcoreReady example. please see #15 (comment)

@aryaantony92
Copy link
Contributor

we should add not remove pimcoreReady example. please see #15 (comment)

Done in #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryaantony92 aryaantony92

Labels
Bug
Projects
None yet
Milestone
v2.0.1
Development

No branches or pull requests
4 participants
@dvesh3 @kingjia90 @martineiber @aryaantony92