Remove bunch of allocations from the builders #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
referring_api
branch
2 times, most recently
from
51ce741 to
b209961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks the api a bit if somebody used Strings. Now we allocate a new string only when creating the result JSON. To have this I needed remove the implementation for
Servicetrait to have somehow sane lifetime requirements for theClient. If anybody depended on the Service, I'm not merging this right away and need to think of something.This should bump the version to 0.3.0 when released, but first we're running some tests how much faster we get with these changes.
h0x @dbrgn