Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore customers who might be test customers #252

Merged
merged 1 commit into from
Sep 18, 2016

Conversation

streeter
Copy link
Contributor

@streeter streeter commented Apr 7, 2016

We could examine to see if the message also contains a similar object exists in test mode, but wasn't sure if that was something I should also do.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.733% when pulling 488eb79 on streeter:sync-commands into 9b9cf91 on pinax:master.

@ossanna16
Copy link
Contributor

Thanks for the PR @streeter! :) @paltman Thoughts on @streeter's suggestion?

@jtauber jtauber modified the milestone: post-16.07 Jul 28, 2016
@paltman
Copy link
Contributor

paltman commented Jul 28, 2016

@streeter can you make sure to look into why coverage dropped and fix it?

@coveralls
Copy link

coveralls commented Aug 1, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5bb5ca0 on streeter:sync-commands into e310775 on pinax:master.

@streeter
Copy link
Contributor Author

streeter commented Aug 1, 2016

@paltman I added a test to fix that coverage drop.

@ossanna16
Copy link
Contributor

Thank you @streeter!

@paltman paltman merged commit 0c409f5 into pinax:master Sep 18, 2016
@paltman
Copy link
Contributor

paltman commented Sep 18, 2016

Thanks @streeter

@streeter streeter deleted the sync-commands branch September 19, 2016 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants