Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added protection against creating duplicate customers. #305

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Added protection against creating duplicate customers. #305

merged 1 commit into from
Dec 21, 2016

Conversation

freakboy3742
Copy link
Contributor

This can happen relatively easily if you put all stripe API calls into tasks. If you have two tasks which create the customer at the same time, you end up with an IntegrityError on one of the calls (because the OneToOne relation can't be formed), but two records in your Stripe account (because the stripe calls both succeed).

@coveralls
Copy link

coveralls commented Dec 21, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 94b28dc on jambonsw:duplicate_customer into 1f8d937 on pinax:master.

@paltman paltman merged commit acc400e into pinax:master Dec 21, 2016
@paltman
Copy link
Contributor

paltman commented Dec 21, 2016

Thanks!

@freakboy3742 freakboy3742 deleted the duplicate_customer branch December 21, 2016 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants