Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully dump stats before exiting on Ctrl-C #178

Open
jonathanzxu opened this issue Jul 11, 2024 · 1 comment
Open

Gracefully dump stats before exiting on Ctrl-C #178

jonathanzxu opened this issue Jul 11, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jonathanzxu
Copy link
Contributor

Users can only get cumulative recall and latency metrics at the very end of a run, after completion; this is sometimes wasteful as information is lost if the user kills the process early. Allow VSB to catch a SIGINT and dump useful cumulative stats before exiting.

@jonathanzxu jonathanzxu added the enhancement New feature or request label Jul 11, 2024
@daverigby
Copy link
Collaborator

This probably boils down to a revert of 66d6d42, perhaps adding a warning message if the stats are partial (environment.shape_class.finished is False).

@daverigby daverigby added the good first issue Good for newcomers label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants