Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

remove awkward go.mod prepare #881

Open
gregwebs opened this issue Mar 16, 2021 · 2 comments
Open

remove awkward go.mod prepare #881

gregwebs opened this issue Mar 16, 2021 · 2 comments
Labels
type/feature-request New feature or request

Comments

@gregwebs
Copy link
Contributor

Feature Request

The go.mod prepare step in this Makefile of this project can make it confusing to add a new dependency.

I am hoping this was added due to issues with older go versions and it can be removed now?

@gregwebs gregwebs added the type/feature-request New feature or request label Mar 16, 2021
@kennytm
Copy link
Collaborator

kennytm commented Mar 16, 2021

@gregwebs unfortunately as long as there is a cyclic dependency between BR and TiDB we can't avoid the go.mod1 trick 😢 (#554).

@gregwebs
Copy link
Contributor Author

Okay, then the solution is to break the cycle. I am not familiar enough with Go modules to know if this necessitates multiple go.mod files in a single repo. But probably the core tidb code can be exposed as a library and kept separate from the in-process backup.

Keeping this issue open may help someone else who comes across this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants