Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

check whether the master's address can be connected before enter the dmctl's interaction moded #571

Closed
WangXiangUSTC opened this issue Mar 25, 2020 · 0 comments · Fixed by #786
Closed

check whether the master's address can be connected before enter the dmctl's interaction moded #571

WangXiangUSTC opened this issue Mar 25, 2020 · 0 comments · Fixed by #786
Assignees
@GMHDBJD
Labels
challenge-program-2 difficulty/easy type/feature-request This issue is a feature request

Comments

@WangXiangUSTC
Copy link
Contributor

WangXiangUSTC commented Mar 25, 2020 •
edited by csuzhangxc
Loading

Feature Request

Is your feature request related to a problem? Please describe:

dmctl can go into interactive mode even if the master's address is invalid, and will get a connection error when execute command in interactive mode

企业微信20200325011150

Describe the feature you'd like:

should try to connect to the master before go into interactive mode, and return error if connect failed, just like:

 ./bin/dmctl --master-addr "127.0.0.1:8262"
can't connect to 127.0.0.1:8261, error XXX......

Score

100

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • Golang
  • Experience with DM

Learning Materials
@WangXiangUSTC WangXiangUSTC added the type/feature-request This issue is a feature request label Mar 25, 2020
@WangXiangUSTC WangXiangUSTC changed the title dmctl can go into interactive mode even if the master's address is invalid UCP: check whether the master's address can be connected before enter the dmctl's interaction moded Mar 31, 2020
@WangXiangUSTC WangXiangUSTC changed the title UCP: check whether the master's address can be connected before enter the dmctl's interaction moded check whether the master's address can be connected before enter the dmctl's interaction moded Jul 6, 2020
@GMHDBJD GMHDBJD self-assigned this Jul 7, 2020
@GMHDBJD GMHDBJD mentioned this issue Jul 7, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GMHDBJD GMHDBJD

Labels
challenge-program-2 difficulty/easy type/feature-request This issue is a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dmctl: check master connection when start. GMHDBJD/dm
3 participants
@WangXiangUSTC @sre-bot @GMHDBJD