Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect message for set_var() #19119

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix incorrect message for set_var() #19119

merged 4 commits into from
Nov 25, 2024

Conversation

songrijie
Copy link
Contributor

@songrijie songrijie commented Nov 18, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

Fix incorrect messages for set_var()

  • tidb_read_consistency is supported conditionally
  • tidb_read_staleness is not support

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@songrijie songrijie requested a review from hfxsd November 18, 2024 14:43
@songrijie songrijie mentioned this pull request Nov 18, 2024
Merged
16 tasks
@lilin90 lilin90 self-assigned this Nov 19, 2024
@lilin90 lilin90 added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Nov 19, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 19, 2024
@lilin90 lilin90 added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. and removed missing-translation-status This PR does not have translation status info. labels Nov 19, 2024
lilin90
lilin90 reviewed Nov 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Nov 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Nov 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@lilin90 lilin90 requested a review from winoros November 19, 2024 07:02
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 20, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lilin90
lilin90 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-20 06:52:28.261013277 +0000 UTC m=+14535.880667793: ☑️ agreed by lilin90.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 21, 2024

@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 added the lgtm label Nov 25, 2024
lilin90
lilin90 reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0c7e707 into master Nov 25, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix_set_var_staleness_read branch November 25, 2024 07:57
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19162.

This was referenced Nov 25, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19163.

This was referenced Nov 25, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19164.

This was referenced Nov 25, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
fix incorrect message for set_var() (#19119) (#19163)
3a553e2
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
fix incorrect message for set_var() (#19119) (#19162)
a765141
ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
@ti-chi-bot
fix incorrect message for set_var() (#19119) (#19164)
707d77a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@joey-yez joey-yez joey-yez approved these changes

@winoros winoros winoros approved these changes

@hfxsd hfxsd Awaiting requested review from hfxsd

Assignees

@lilin90 lilin90

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@songrijie @ti-chi-bot @winoros @lilin90 @joey-yez