Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

make conf.SortByPk configurable #231

Open
lichunzhu opened this issue Jan 11, 2021 · 1 comment
Open

make conf.SortByPk configurable #231

lichunzhu opened this issue Jan 11, 2021 · 1 comment
Labels
good first issue priority/P2 Medium priority issue

Comments

@lichunzhu
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

In dumpling we have variable conf.SortByPk. When it's false, dumpling won't add order by clause after the original select SQL. However, it's always set to true and not configurable now.

Describe the feature you'd like:

make conf.SortByPk configurable
The argument could be either --order-by-pk, --sort-by-pk, --order

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Optimization:

@lichunzhu lichunzhu added good first issue priority/P2 Medium priority issue labels Jan 11, 2021
@lichunzhu
Copy link
Contributor Author

Relative problem: https://asktug.com/t/topic/67660/8

Open this argument may cause lightning to insert data without order. Need more estimation to do this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue priority/P2 Medium priority issue
Projects
None yet
Development

No branches or pull requests

1 participant