New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CREATE DATABASE … ENCRYPTION syntax #417

Closed

kennytm opened this issue Jul 30, 2019 · 1 comment

Contributor

kennytm commented Jul 30, 2019

Index Issue: pingcap/tidb#11486

These are bad (incompatible) SQL cases:

(Ref: https://dev.mysql.com/doc/refman/8.0/en/create-database.html)

CREATE DATABASE t ENCRYPTION = 'N';
CREATE DATABASE t ENCRYPTION 'N';
CREATE DATABASE t DEFAULT ENCRYPTION = 'N';
CREATE DATABASE t DEFAULT ENCRYPTION 'N';

-- the following should warn
CREATE DATABASE t ENCRYPTION = 'Y';
CREATE DATABASE t ENCRYPTION 'Y';
CREATE DATABASE t DEFAULT ENCRYPTION = 'Y';
CREATE DATABASE t DEFAULT ENCRYPTION 'Y';

Claim this subtask based on the comments below this issue.

zier-one mentioned this issue

Improve parser compatibility pingcap/tidb#11486

Closed

58 tasks

Contributor

zhenghaoz commented Aug 8, 2019

Let me fix it

zhenghaoz mentioned this issue

Fix CREATE DATABASE … ENCRYPTION syntax #450

Merged

zier-one closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment