Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new privilege for the set config statement #826

Closed
qw4990 opened this issue Apr 23, 2020 · 4 comments · Fixed by #835
Closed

Introduce a new privilege for the set config statement #826

qw4990 opened this issue Apr 23, 2020 · 4 comments · Fixed by #835
Assignees

Comments

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

Feature Request

Describe the feature you'd like:

After #768, we can use set config on TiDB to update configs of TiKV/PD.
Now the privilege of this statement is PrivSuper, which is not appropriate.
We should introduce a new privilege for it.

Describe alternatives you've considered:

No

@qw4990 qw4990 self-assigned this Apr 23, 2020
@kennytm
Copy link
Contributor

kennytm commented Apr 23, 2020

if not super privilege, would that user be allowed to change privileged settings like:?

set config security.skip-grant-table = true;

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 23, 2020

if not super privilege, would that user be allowed to change privileged settings like:?

set config security.skip-grant-table = true;

@tiancaiamao Could you please give us some suggestions about this case...

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 26, 2020

if not super privilege, would that user be allowed to change privileged settings like:?

set config security.skip-grant-table = true;

After discussing with @tiancaiamao , we decide to handle security config items especially, which require both SuperPriv and SetConfPriv when modifying.

@tiancaiamao
Copy link
Collaborator

tiancaiamao commented Apr 26, 2020

Allow the modification of skip-grant-table dynamically would become a vulnerability.
Skip grant table is a special config which is used for disaster recovering from user's misoperation, maybe we do not have the necessity to dynamic change this config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants