Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduleres: label scheduler takes care of unhealthy regions. #1079

Merged
merged 2 commits into from
May 18, 2018
Merged

scheduleres: label scheduler takes care of unhealthy regions. #1079

merged 2 commits into from
May 18, 2018

Conversation

disksing
Copy link
Contributor

Currently unhealthy regions are ignored by label scheduler.

Consider we have IDC1, IDC2, IDC3. IDC3 is configured as 'reject leader'. If IDC1 and IDC3 have network problem or one of IDC1's tikv is down, regions whose leader in IDC3 will be unhealthy, so they will not be able to transfer leader to IDC2.

@disksing disksing added component/schedule Scheduling logic. needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. labels May 18, 2018
nolouch
nolouch approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Connor1996
Connor1996 reviewed May 18, 2018
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing merged commit eb9e6db into tikv:master May 18, 2018
@disksing disksing deleted the reject-leader2 branch May 18, 2018 14:56
disksing added a commit to oh-my-tidb/pd that referenced this pull request May 19, 2018
@disksing
scheduleres: label scheduler takes care of unhealthy regions. (tikv#1079
6ec3303 
)
disksing added a commit that referenced this pull request May 20, 2018
@disksing
cherry-pick commits to release-2.0. (#1080)
2a6f356 
* schedule: filter disconnected stores for leader transfer. (#1072)

* schedule: use shorter timeout for operator contains only leader transfer. (#1077)

* scheduleres: label scheduler takes care of unhealthy regions. (#1079)

* scheduler: evict-leader-scheduler checks reject-leader property. (#1073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 left review comments

@nolouch nolouch nolouch approved these changes

@siddontang siddontang Awaiting requested review from siddontang

Assignees
No one assigned
Labels
component/schedule Scheduling logic. needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disksing @nolouch @Connor1996