simulator: add statistics for simulator #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
reviewed
Aug 29, 2018
| @@ -179,6 +180,16 @@ func (t *transferLeader) Step(r *RaftEngine) { | |||
| t.finished = true | |||
| r.SetRegion(region) | |||
| r.recordRegionChange(region) | |||
| fromPeerID := t.fromPeer.GetId() | |||
| toPeerID := t.peer.GetId() | |||
| _, ok := r.schedulerStats.taskStats.transferLeader[fromPeerID] | |||
There was a problem hiding this comment.
Can we let the Stats just Observe the task and the statistical behavior is handled in observe？
disksing
reviewed
Aug 29, 2018
cmd/simulator/main.go
Outdated
| @@ -174,6 +174,7 @@ EXIT: | |||
| } | |||
|
|
|||
| fmt.Printf("%s [%s] total iteration: %d, time cost: %v\n", simResult, confName, driver.TickCount(), time.Since(start)) | |||
| driver.Print() | |||
There was a problem hiding this comment.
How about PrintStatistics ?
|
Could you post some output example? |
|
@disksing Here is an example of the |
disksing
approved these changes
Aug 30, 2018
nolouch
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (required)
This PR add some statistics for simulator, such as task statistics and snapshot statistics.
What are the type of the changes (required)?
How has this PR been tested (required)?