schedule: change merge match peers strategy #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Connor1996 CI failed. |
disksing
reviewed
Nov 26, 2018
|
@nolouch Because |
|
@Connor1996 Any update? Maybe you can make sure regions have only 1 intersection. |
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Connor1996
changed the title
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
| steps = append(steps, RemovePeer{FromStore: peer.GetStoreId()}) | ||
| kind |= OpRegion | ||
| index++ |
There was a problem hiding this comment.
Please check if index == len(toAdds) after this loop.
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Connor1996
added a commit
to Connor1996/pd
that referenced
this pull request
Dec 11, 2018
* change merge leader strategy
Connor1996
added a commit
to Connor1996/pd
that referenced
this pull request
Dec 11, 2018
* change merge leader strategy
Connor1996
added a commit
that referenced
this pull request
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There is a case that a follower is added and transfer leader to it, and the apply process of it is slow so leader regards it as a voter but actually it is still a learner. Once that, the follower can't be a leader, but the old leader can't know that so there is no leader to serve for a while.
What is changed and how it works?
change merge match peers strategy, transfer leader to the first added follower if there is no intersection store, and remove one peer after adding one peer.
Check List