Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/leader: use the compact revision to watch leader #1396

Merged
merged 9 commits into from
Dec 29, 2018

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 26, 2018

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Use the current version may be lost the watch history, use compact version instead.

What is changed and how it works?

use the compact revision to watch leader

Check List

Tests

  • Unit test
  • Integration test

@nolouch nolouch added the type/bug The issue is confirmed as a bug. label Dec 26, 2018
Signed-off-by: nolouch <nolouch@gmail.com>
@rleungx
Copy link
Member

rleungx commented Dec 26, 2018

/rebuild

@rleungx
Copy link
Member

rleungx commented Dec 26, 2018

/rebuild

@disksing disksing added the needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. label Dec 26, 2018
@nolouch nolouch requested review from rleungx and disksing December 28, 2018 03:44
Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huachaohuang
Copy link
Contributor

Unit test keeps failing, does it related to this PR?

@nolouch
Copy link
Contributor Author

nolouch commented Dec 29, 2018

/run-unit-test

@nolouch
Copy link
Contributor Author

nolouch commented Dec 29, 2018

seems the ci environment not stable.

@nolouch
Copy link
Contributor Author

nolouch commented Dec 29, 2018

/run-unit-test

@nolouch nolouch merged commit 5e5c092 into tikv:master Dec 29, 2018
@nolouch nolouch deleted the use-minversion branch December 29, 2018 07:25
nolouch added a commit to nolouch/pd that referenced this pull request Jan 3, 2019
* server/leader: use the compact revision to watch leader

Signed-off-by: nolouch <nolouch@gmail.com>
rleungx pushed a commit that referenced this pull request Jan 9, 2019
* server/leader: use the compact revision to watch leader

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants