-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/leader: use the compact revision to watch leader #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
force-pushed
the
use-minversion
branch
from
December 26, 2018 04:05
b970b14
to
e741d70
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
use-minversion
branch
from
December 26, 2018 04:09
e741d70
to
5b04088
Compare
/rebuild |
/rebuild |
disksing
added
the
needs-cherry-pick-release-2.1
The PR needs to cherry pick to release-2.1 branch.
label
Dec 26, 2018
disksing
reviewed
Dec 26, 2018
huachaohuang
approved these changes
Dec 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unit test keeps failing, does it related to this PR? |
/run-unit-test |
seems the ci environment not stable. |
rleungx
approved these changes
Dec 29, 2018
/run-unit-test |
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jan 3, 2019
* server/leader: use the compact revision to watch leader Signed-off-by: nolouch <nolouch@gmail.com>
rleungx
pushed a commit
that referenced
this pull request
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cherry-pick-release-2.1
The PR needs to cherry pick to release-2.1 branch.
type/bug
The issue is confirmed as a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Use the current version may be lost the watch history, use compact version instead.
What is changed and how it works?
use the compact revision to watch leader
Check List
Tests