*: add the scheduling configuration metrics #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rleungx <rleungx@gmail.com>
huachaohuang
reviewed
Jan 3, 2019
| disableReplaceOfflineReplica = 1 | ||
| } | ||
|
|
||
| configs["disable_makeup_replica"] = disableMakeUpReplica |
There was a problem hiding this comment.
Can we just do configs["disable_makeup_replica"] = !s.opt.IsMakeUpReplicaEnabled()?
There was a problem hiding this comment.
It seems we can not convert bool to float64 here.
nolouch
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For now, we can only find the parameters of the configuration through the log, which is not friendly.
What is changed and how it works?
This PR adds some important configurations into metrics.
Check List
tidb-ansiblerepository