Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: make heartbeat more reasonable #1418

Merged
merged 5 commits into from
Mar 7, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 24, 2019

What problem does this PR solve?

Currently, if one store is going to send the heartbeat, it needs to wait until the previous one finishes it.

What is changed and how it works?

This PR tries to use different goroutines to do these jobs.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #1418 into master will decrease coverage by 0.47%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   68.01%   67.53%   -0.48%     
==========================================
  Files         158      158              
  Lines       15208    15261      +53     
==========================================
- Hits        10344    10307      -37     
- Misses       3950     4025      +75     
- Partials      914      929      +15
Impacted Files Coverage Δ
tools/pd-simulator/simulator/drive.go 0% <0%> (ø) ⬆️
tools/pd-simulator/simulator/raft.go 14.82% <0%> (-0.71%) ⬇️
tools/pd-simulator/simulator/task.go 0% <0%> (ø) ⬆️
tools/pd-simulator/simulator/statistics.go 0% <0%> (ø) ⬆️
tools/pd-simulator/simulator/node.go 0% <0%> (ø) ⬆️
pkg/tempurl/tempurl.go 57.14% <0%> (-14.29%) ⬇️
server/etcd_kv.go 63.63% <0%> (-10.91%) ⬇️
server/leader.go 80.25% <0%> (-7.15%) ⬇️
server/namespace_cluster.go 84.41% <0%> (-3.9%) ⬇️
server/util.go 70.27% <0%> (-2.71%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408348e...c674965. Read the comment docs.

tools/pd-simulator/simulator/node.go Outdated Show resolved Hide resolved
tools/pd-simulator/simulator/node.go Outdated Show resolved Hide resolved
Signed-off-by: rleungx <rleungx@gmail.com>
Signed-off-by: rleungx <rleungx@gmail.com>
Signed-off-by: rleungx <rleungx@gmail.com>
@rleungx rleungx force-pushed the simulator-heartbeat branch from 7a4ad5f to 4ae77b1 Compare February 19, 2019 03:01
@rleungx
Copy link
Member Author

rleungx commented Feb 20, 2019

/rebuild

@nolouch nolouch merged commit 2fe8598 into tikv:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants