-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulator: make heartbeat more reasonable #1418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
- Coverage 68.01% 67.53% -0.48%
==========================================
Files 158 158
Lines 15208 15261 +53
==========================================
- Hits 10344 10307 -37
- Misses 3950 4025 +75
- Partials 914 929 +15
Continue to review full report at Codecov.
|
disksing
reviewed
Feb 11, 2019
Signed-off-by: rleungx <rleungx@gmail.com>
Signed-off-by: rleungx <rleungx@gmail.com>
Signed-off-by: rleungx <rleungx@gmail.com>
rleungx
force-pushed
the
simulator-heartbeat
branch
from
February 19, 2019 03:01
7a4ad5f
to
4ae77b1
Compare
/rebuild |
disksing
approved these changes
Mar 4, 2019
nolouch
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, if one store is going to send the heartbeat, it needs to wait until the previous one finishes it.
What is changed and how it works?
This PR tries to use different goroutines to do these jobs.
Check List
Tests