Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix GetHotStores #1487

Merged
merged 1 commit into from
Mar 29, 2019
Merged

api: fix GetHotStores #1487

merged 1 commit into from
Mar 29, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 29, 2019

What problem does this PR solve?

Currently, GetHotStores will return the same value for KeysRead and KeysWritten.

What is changed and how it works?

This PR fixes this problem and improves the test.

Check List

Tests

  • Unit test

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1487 into master will increase coverage by 0.16%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
+ Coverage    67.2%   67.37%   +0.16%     
==========================================
  Files         158      158              
  Lines       15385    15385              
==========================================
+ Hits        10339    10365      +26     
+ Misses       4107     4084      -23     
+ Partials      939      936       -3
Impacted Files Coverage Δ
server/schedule/mockcluster.go 83.85% <0%> (ø) ⬆️
server/api/hot_status.go 100% <100%> (ø) ⬆️
pkg/metricutil/metricutil.go 90.62% <0%> (-6.25%) ⬇️
server/util.go 70.27% <0%> (-2.71%) ⬇️
server/leader.go 81.51% <0%> (+0.42%) ⬆️
server/option.go 91.25% <0%> (+0.83%) ⬆️
server/cluster_info.go 86.04% <0%> (+0.83%) ⬆️
server/handler.go 55.87% <0%> (+1.3%) ⬆️
server/core/kv.go 76.81% <0%> (+1.44%) ⬆️
server/region_syncer/server.go 83.62% <0%> (+1.72%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329082d...9f8bd85. Read the comment docs.

@hicqu
Copy link
Contributor

hicqu commented Mar 29, 2019

LGTM.

@nolouch nolouch merged commit 56f4100 into tikv:master Mar 29, 2019
bradyjoestar added a commit to bradyjoestar/pd that referenced this pull request Mar 30, 2019
@nolouch nolouch added the needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. label Mar 31, 2019
bradyjoestar added a commit to bradyjoestar/pd that referenced this pull request Apr 1, 2019
nolouch pushed a commit to nolouch/pd that referenced this pull request Apr 2, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch added a commit that referenced this pull request Apr 3, 2019
* scheduler: fix region scatter may transfer leader to removed peer (#1482)

* scheduler: fix region scatter may transfer leader to removed peer

Signed-off-by: nolouch <nolouch@gmail.com>

* fix get hot store (#1487)

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants