-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: turn the default limit of the hot region schedule #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added
the
needs-cherry-pick-release-3.0
The PR needs to cherry pick to release-3.0 branch.
label
Jul 3, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
Should it be mentioned in release note? Because users need to manually update config value for old clusters. |
@disksing Yes, we should. also, update the 3.0 upgrade guide. |
shafreeck
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rleungx
approved these changes
Jul 4, 2019
nolouch
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
Jul 4, 2019
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Jul 10, 2019
* config: turn the default limit of the hot region schedule Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
pushed a commit
that referenced
this pull request
Jul 11, 2019
* schedulers: balance region consider pending peer (#1617) * schedulers: balance region consider pending peers Signed-off-by: nolouch <nolouch@gmail.com> * scheduler: check replica for hot region (#1609) * check replica for hot region scheduler Signed-off-by: Ryan Leung <rleungx@gmail.com> * schedule: set influence according to region size (#1613) * not consider store limit when executing merge Signed-off-by: Ryan Leung <rleungx@gmail.com> * set influence according to region size Signed-off-by: Ryan Leung <rleungx@gmail.com> * fix race problems Signed-off-by: Ryan Leung <rleungx@gmail.com> * config: turn the default limit of the hot region schedule (#1616) * config: turn the default limit of the hot region schedule Signed-off-by: nolouch <nolouch@gmail.com> * update CHANGELOG Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cherry-pick-release-3.0
The PR needs to cherry pick to release-3.0 branch.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
now, the
balance-region-limit
already enlarge, also makehot-region-schedule-limit
more suitable.What is changed and how it works?
enlarge limit.
Check List
Tests