Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add retry mechanism for join #1643

Merged
merged 5 commits into from
Jul 22, 2019
Merged

server: add retry mechanism for join #1643

merged 5 commits into from
Jul 22, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 17, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

related: pingcap/tidb-operator#568.

What is changed and how it works?

Add retry mechanism for join

Check List

Tests

  • Unit test
  • Integration test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. label Jul 17, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
server/join.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor Author

nolouch commented Jul 19, 2019

PTAL @disksing @rleungx

@rleungx
Copy link
Member

rleungx commented Jul 19, 2019

/ok-to-test

1 similar comment
@nolouch
Copy link
Contributor Author

nolouch commented Jul 22, 2019

/ok-to-test

@zyxbest
Copy link

zyxbest commented Jul 22, 2019

/run-all-tests

@tikv tikv deleted a comment from sre-bot Jul 22, 2019
@nolouch nolouch merged commit 3700c71 into tikv:master Jul 22, 2019
nolouch added a commit to nolouch/pd that referenced this pull request Aug 5, 2019
* server/join: add retry for join member

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants