-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
placement: remove stale code #1855
Conversation
Signed-off-by: disksing <i@disksing.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What did they originally plan to be used for?
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 77.97% 77.84% -0.14%
==========================================
Files 168 166 -2
Lines 17034 16895 -139
==========================================
- Hits 13283 13152 -131
+ Misses 2664 2659 -5
+ Partials 1087 1084 -3
Continue to review full report at Codecov.
|
@lhy1024 Same target. But design is not good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Remove some code based on staled design (never used).
Check List
Tests