Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: remove stale code #1855

Merged
merged 2 commits into from
Oct 29, 2019
Merged

placement: remove stale code #1855

merged 2 commits into from
Oct 29, 2019

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Remove some code based on staled design (never used).

Check List

Tests

  • No code

Signed-off-by: disksing <i@disksing.com>
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did they originally plan to be used for?

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1855 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
- Coverage   77.97%   77.84%   -0.14%     
==========================================
  Files         168      166       -2     
  Lines       17034    16895     -139     
==========================================
- Hits        13283    13152     -131     
+ Misses       2664     2659       -5     
+ Partials     1087     1084       -3
Impacted Files Coverage Δ
pkg/mock/mockcluster/mockcluster.go 90.2% <0%> (-1.75%) ⬇️
server/grpc_service.go 57.04% <0%> (-0.66%) ⬇️
client/client.go 68.6% <0%> (-0.44%) ⬇️
server/cluster.go 84.49% <0%> (-0.25%) ⬇️
server/schedule/operator/operator.go 85.53% <0%> (+0.35%) ⬆️
server/schedulers/shuffle_hot_region.go 61.79% <0%> (+5.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd1e8b...597dc08. Read the comment docs.

@lhy1024 lhy1024 added the type/refactor The issue belongs to a refactor work. label Oct 29, 2019
@disksing
Copy link
Contributor Author

@lhy1024 Same target. But design is not good.

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx rleungx added the status/can-merge Indicates a PR has been approved by a committer. label Oct 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit 8d86658 into tikv:master Oct 29, 2019
@disksing disksing mentioned this pull request Dec 13, 2019
9 tasks
@disksing disksing deleted the placement4 branch March 5, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants