Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the max recv message size for the client #1952

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 18, 2019

What problem does this PR solve?

PR #1739 accidentally removes the max gRPC receive message size constraint for the client.

What is changed and how it works?

This PR fixes it by adding it back.

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release notes

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Nov 18, 2019
@rleungx
Copy link
Member Author

rleungx commented Nov 18, 2019

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 19, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7a5909e into tikv:release-3.0 Nov 19, 2019
rleungx added a commit to rleungx/pd that referenced this pull request Nov 25, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch pushed a commit that referenced this pull request Nov 25, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants