Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server, client: add down_peer and pending_peer in region response (#2429) #2443

Merged
merged 6 commits into from
May 25, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 22, 2020

cherry-pick #2429 to release-4.0


What problem does this PR solve?

TiDB needs to identify down and pending peers to first connect to good peer.

What is changed and how it works?

  • update kvproto
  • return down peers and pending peers list
  • update pd client

Check List

Tests

  • Unit test

Side effects

  • Breaking backward compatibility (pd client has interface changed)

Related changes

Release note

  • Add DownPeers and PendingPeers in region response

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@nolouch
Copy link
Contributor

nolouch commented May 22, 2020

need to cherry picker #2435 ?

@nolouch nolouch modified the milestones: v4.0.0-rc.2, v4.0.0-ga May 22, 2020
@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/run-all-tests

@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

@sre-bot merge failed.

@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/run-all-tests

1 similar comment
@jebter
Copy link
Collaborator

jebter commented May 25, 2020

/run-all-tests

@jebter jebter merged commit 2303e3a into tikv:release-4.0 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants