-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: fast-fail if the leader changed to the RemovePeer (#2530) #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added
the
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
label
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2551 +/- ##
===============================================
- Coverage 77.16% 77.06% -0.11%
===============================================
Files 204 204
Lines 21940 22011 +71
===============================================
+ Hits 16931 16963 +32
- Misses 3724 3744 +20
- Partials 1285 1304 +19
Continue to review full report at Codecov.
|
disksing
approved these changes
Jun 18, 2020
rleungx
approved these changes
Jun 18, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jun 18, 2020
/run-all-tests |
@nolouch merge failed. |
lhy1024
approved these changes
Jun 18, 2020
/merge |
/run-all-tests |
1 similar comment
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/schedule
Scheduling logic.
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
status/can-merge
Indicates a PR has been approved by a committer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Fix #2493
If the leader changed cause by TiKV(maybe too busy or network problem), the operator cannot step to the final state, such as
Then the operator needs 10mins to timeout, which may cause the rule sync learner became slow.
What is changed and how it works?
Check List
Tests
Release note