-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: revert low space threshold hard limit (#2864) #2875
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/merge |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2875 +/- ##
===============================================
- Coverage 77.37% 77.37% -0.01%
===============================================
Files 208 208
Lines 22765 22762 -3
===============================================
- Hits 17615 17612 -3
+ Misses 3822 3816 -6
- Partials 1328 1334 +6
Continue to review full report at Codecov.
|
@ti-srebot merge failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry-pick #2864 to release-4.0
What problem does this PR solve?
The previous PR uses a hard limit for low space. If the capacity beyond 500G, it will use 100G as its low space threshold. It doesn't seem reasonable.
What is changed and how it works?
This PR changes back to the original way to control low space.
Check List
Tests
Related changes
Release note