Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: fix miss err in redirectSchedulerDelete (#2973) #2974

Merged
merged 1 commit into from
Sep 17, 2020
Merged

api: fix miss err in redirectSchedulerDelete (#2973) #2974

merged 1 commit into from
Sep 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2973 to release-4.0

What problem does this PR solve?

api: fix miss err in redirectSchedulerDelete

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

  • fix miss err in redirectSchedulerDelete

@lhy1024 @ti-srebot
cherry pick tikv#2973 to release-4.0
10fccd3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 16, 2020
Merged
@ti-srebot ti-srebot added component/api HTTP API. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Sep 16, 2020
@ti-srebot ti-srebot added this to the v4.0.7 milestone Sep 16, 2020
@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #2974 into release-4.0 will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2974      +/-   ##
===============================================
- Coverage        77.45%   77.42%   -0.03%     
===============================================
  Files              209      209              
  Lines            22866    22866              
===============================================
- Hits             17711    17705       -6     
- Misses            3821     3823       +2     
- Partials          1334     1338       +4
Impacted Files Coverage Δ
server/api/scheduler.go 41.80% <100.00%> (ø)
server/heartbeat_streams.go 68.00% <0.00%> (-6.00%) ⬇️
server/tso/tso.go 78.48% <0.00%> (-1.27%) ⬇️
server/core/storage.go 72.86% <0.00%> (-0.78%) ⬇️
server/server.go 76.92% <0.00%> (-0.45%) ⬇️
server/cluster/cluster.go 80.89% <0.00%> (-0.21%) ⬇️
server/grpc_service.go 61.09% <0.00%> (+0.18%) ⬆️
client/client.go 72.57% <0.00%> (+0.47%) ⬆️
server/member/leader.go 74.61% <0.00%> (+0.76%) ⬆️
pkg/btree/btree.go 87.65% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeaac24...10fccd3. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Sep 16, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2020
@nolouch
Copy link
Contributor

nolouch commented Sep 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 16, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 16, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@rleungx
Copy link
Member

rleungx commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-lightning-test

2 similar comments
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-lightning-test

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-lightning-test

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@glorv
Copy link
Contributor

glorv commented Sep 17, 2020

/run-integration-lightning-test

1 similar comment
@glorv
Copy link
Contributor

glorv commented Sep 17, 2020

/run-integration-lightning-test

@lhy1024 lhy1024 closed this Sep 17, 2020
@lhy1024 lhy1024 reopened this Sep 17, 2020
@glorv
Copy link
Contributor

glorv commented Sep 17, 2020

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-lightning-test

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/build

1 similar comment
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/build

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2983

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2983

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2983
  • 2983
  • 2983

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2983
  • 2983

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2983
  • 2983

@ti-srebot ti-srebot merged commit 2abf45a into tikv:release-4.0 Sep 17, 2020
@disksing disksing deleted the release-4.0-e7735ba3ad67 branch September 17, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@lhy1024 lhy1024

Labels
component/api HTTP API. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
v4.0.7
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @nolouch @lhy1024 @rleungx @glorv @HunDunDM