scheduler: add leader verify in balance-region scheduler (#2966) #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
added
status/LGT2
lhy1024
approved these changes
Sep 18, 2020
ti-srebot
added
status/LGT1
Signed-off-by: Song Gao <disxiaofei@163.com>
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-all-tests |
HunDunDM
reviewed
Sep 21, 2020
server/schedulers/balance_test.go
Outdated
| func (s *testBalanceRegionSchedulerSuite) TestShouldNotBalance(c *C) { | ||
| opt := config.NewTestOptions() | ||
| tc := mockcluster.NewCluster(opt) | ||
| tc.DisableFeature(versioninfo.JointConsensus) |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-integration-ddl-test |
|
/run-integration-lightning-test |
|
/merge |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-integration-lightning-test |
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2966 to release-4.0
Signed-off-by: Song Gao disxiaofei@163.com
What problem does this PR solve?
If the region have no leader during balance-region, it will pause PD panic and restart over and over.
What is changed and how it works?
Check region leader before balance region. If it has no leader, the balance for this region would be skipped.
Check List
Tests
Related changes
Release note
balance-regionenabled.