Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: create operator to match leader role (#3133) #3208

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3133 to release-4.0


Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Fix #3130

We only have 'follower' -> 'none follower' logic, no 'none leader' -> 'leader'

What is changed and how it works?

  • add 'none leader' -> 'leader' logic
  • update metrics name to distinguish different types of operators
  • add test

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that the leader role does not take effect when using the replacement rule in some cases

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added component/placement Placement rule. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick labels Nov 25, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

@disksing you're already a collaborator in bot's repo.

@disksing
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HunDunDM
Copy link
Member

/run-all-tests

@nolouch
Copy link
Contributor

nolouch commented Nov 25, 2020

/run-integration-compatibility-test

@nolouch
Copy link
Contributor

nolouch commented Nov 25, 2020

/run-integration-lightning-test

@nolouch
Copy link
Contributor

nolouch commented Nov 25, 2020

/run-integration-compatibility-test

@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 527f4a0

@nolouch
Copy link
Contributor

nolouch commented Nov 25, 2020

/run-integration-compatibility-test

@ti-chi-bot ti-chi-bot merged commit 6a666f5 into tikv:release-4.0 Nov 25, 2020
@disksing disksing deleted the release-4.0-68f7a8857281 branch November 25, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/placement Placement rule. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants