core: change score calculator in few disk space to avoid offline earlier (#3592) #3605
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
@HunDunDM you're already a collaborator in bot's repo. |
zhouqiang-cl
added
the
cherry-pick-approved
Codecov Report
@@ Coverage Diff @@
## release-5.0 #3605 +/- ##
===============================================
- Coverage 74.60% 74.60% -0.01%
===============================================
Files 245 245
Lines 24122 24124 +2
===============================================
Hits 17997 17997
- Misses 4510 4515 +5
+ Partials 1615 1612 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@nolouch: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
Kudos, SonarCloud Quality Gate passed!
|
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 151720d
|
ti-chi-bot
added
the
status/can-merge
|
/run-integration-ddl-test |
cherry-pick #3592 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In pd repo: git pr https://github.com/tikv/pd/pull/3605After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
issue: #3589
What is changed and how it works?
core regionScoreV2 calculator, store's score will increase rapidly when it disk space less than F
Check List
Tests
Code changes
when I use math to consider score similator in low space：
the score will be mostly affect by C, so their socres is different,the lower disk has few score than higher disk. so it will move region to lower store to run out of disk :
similator ：
What is changed and how it works?
core regionScoreV2 calculator, store's score will increase rapidly when it disk space less than F.
the F param is not 20G, it should be set by the store's disk space , F will be set:
F=max(50,capacity*(1-lowSpaceRatio))
I want to the score should be similar when they has same free space in low disk space, so use linear calculator.
similator result：
test result：
it work well in low space
Side effects
Related changes
Release note