Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix the operator priority (#3694) #3703

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3694

What problem does this PR solve?

To keep consistent with the original implementation.

What is changed and how it works?

This PR adds back the high priority for some kinds of operators.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix the priority problems for some kinds of operators

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /merge) by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/checker Checker logic. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. labels May 24, 2021
@ti-chi-bot ti-chi-bot requested a review from disksing May 24, 2021 11:11
@ti-chi-bot ti-chi-bot requested a review from Yisaer May 24, 2021 11:11
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@disksing
Copy link
Contributor

@rleungx need to fix conflicts

@disksing disksing removed their request for review June 29, 2021 03:17
@nolouch nolouch requested a review from rleungx July 5, 2021 06:09
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 6, 2021
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #3703 (e480fe3) into release-4.0 (b6ac46c) will decrease coverage by 0.09%.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3703      +/-   ##
===============================================
- Coverage        74.89%   74.80%   -0.10%     
===============================================
  Files              211      211              
  Lines            19953    19961       +8     
===============================================
- Hits             14944    14932      -12     
- Misses            3687     3697      +10     
- Partials          1322     1332      +10     
Flag Coverage Δ
unittests 74.80% <60.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker/rule_checker.go 80.12% <60.00%> (-1.63%) ⬇️
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
pkg/etcdutil/etcdutil.go 77.94% <0.00%> (-2.95%) ⬇️
server/member/leader.go 66.97% <0.00%> (-1.84%) ⬇️
pkg/dashboard/adapter/manager.go 85.10% <0.00%> (-1.07%) ⬇️
server/server.go 74.43% <0.00%> (-0.81%) ⬇️
client/client.go 69.03% <0.00%> (-0.51%) ⬇️
pkg/btree/btree.go 86.02% <0.00%> (-0.25%) ⬇️
server/cluster/cluster.go 78.60% <0.00%> (-0.24%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ac46c...e480fe3. Read the comment docs.

@rleungx
Copy link
Member

rleungx commented Jul 6, 2021

@rleungx need to fix conflicts

Fixed

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 6, 2021
@rleungx
Copy link
Member

rleungx commented Jul 6, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 3f089bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit e649fe7 into tikv:release-4.0 Jul 6, 2021
@HunDunDM HunDunDM added this to the v4.0.14 milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/checker Checker logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants