server/cache: add kv to cluster #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more safe to update cache and kv consistenly inside cluster.
huachaohuang
force-pushed
the
huachao/add-kv-to-cluster
branch
from
8d9b537 to
8e41da6
Compare
huachaohuang
changed the title
siddontang
reviewed
Nov 14, 2016
| return c.innerPutMeta(proto.Clone(meta).(*metapb.Cluster)) | ||
| } | ||
|
|
||
| func (c *clusterInfo) innerPutMeta(meta *metapb.Cluster) error { |
There was a problem hiding this comment.
I prefer putMetaLocked which means that we must lock before calling this function.
siddontang
reviewed
Nov 14, 2016
| @@ -243,8 +244,9 @@ func newClusterInfo(id IDAllocator) *clusterInfo { | |||
| } | |||
|
|
|||
| // Return nil if cluster is not bootstrapped. | |||
| func loadClusterInfo(id IDAllocator, kv *kv) (*clusterInfo, error) { | |||
| func newClusterInfoWithKV(id IDAllocator, kv *kv) (*clusterInfo, error) { | |||
There was a problem hiding this comment.
newClusterInfo is ok. you use two args, so WithKV is not proper here.
There was a problem hiding this comment.
We already have a newClusterInfo without kv for test.
There was a problem hiding this comment.
so we should use a better name here.
|
Rest LGTM |
|
PTAL @overvenus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We update cache and kv separately in different places, which may not be safe and hard to maintain.
This PR updates both cache and kv consistently inside
clusterInfo.