cmd: add recover command tool #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
May 25, 2017
cmd/pd-recover/main.go
Outdated
| fmt.Println("cluster already bootstrapped") | ||
| return | ||
| } | ||
| fmt.Println("recover success! please restart PD") |
There was a problem hiding this comment.
Why do we need to restart PD?
There was a problem hiding this comment.
for reload cluster meta info.
cmd/pd-recover/main.go
Outdated
| // recover meta of cluster | ||
| clusterMeta := metapb.Cluster{ | ||
| Id: *clusterID, | ||
| MaxPeerCount: uint32(3), |
There was a problem hiding this comment.
I suppose we need to add it to command line argument.
cmd/pd-recover/main.go
Outdated
| exitErr(err) | ||
| } | ||
| if !resp.Succeeded { | ||
| fmt.Println("cluster already bootstrapped") |
There was a problem hiding this comment.
Make it more like an error message. Such as "failed to recover: the cluster is already bootstrapped"
siddontang
reviewed
May 25, 2017
| ops = append(ops, clientv3.OpPut(clusterRootPath, string(clusterValue))) | ||
|
|
||
| // set raft bootstrap time | ||
| nano := time.Now().UnixNano() |
There was a problem hiding this comment.
strange bootstrap time here...
There was a problem hiding this comment.
maybe we can recover it by dump tikv data later.
siddontang
reviewed
May 25, 2017
|
|
||
| func main() { | ||
| flag.Parse() | ||
| if *clusterID == 0 { |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @disksing @siddontang