*: adjust scheduler interface #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
Oct 14, 2017
server/schedule/scheduler.go
Outdated
| GetResourceKind() core.ResourceKind | ||
| GetResourceLimit() uint64 | ||
| Prepare(cluster Cluster) error | ||
| Cleanup(cluster Cluster) | ||
| Schedule(cluster Cluster) *Operator | ||
| IsAllowSchedule() bool |
There was a problem hiding this comment.
I suppose we can remove GetResourceKind(), GetResourceLimit(), IsAllowSchedule() from interface, Schedulers can check limit by themselves.
There was a problem hiding this comment.
the controller should know IsAllowSchedule. Directly return nil operator will change tick time.
siddontang
reviewed
Oct 14, 2017
server/schedule/scheduler.go
Outdated
| func (l *Limiter) RemoveOperator(op *Operator) { | ||
| l.Lock() | ||
| defer l.Unlock() | ||
| l.counts[op.ResourceKind()]-- |
There was a problem hiding this comment.
need consider overflow here?
|
LGTM. |
siddontang
reviewed
Oct 16, 2017
server/schedule/scheduler.go
Outdated
| Prepare(cluster Cluster) error | ||
| Cleanup(cluster Cluster) | ||
| Schedule(cluster Cluster) *Operator | ||
| IsAllowSchedule() bool |
|
LGTM. |
|
We are going to merge it after GA. |
disksing
approved these changes
Oct 16, 2017
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR do: