Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bit field operator kind. #875

Merged
merged 6 commits into from
Dec 6, 2017
Merged

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Dec 5, 2017

The motivation is that an operator can have more than 1 properties, for instance, both moves a peer and transfers a leader, or both initiated by admin and moves a peer.

return strings.Join(flagNames, "+")
}

// ParseOperatorKind converts string (flag name list concat by '+') to OperatorKind.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using , or |

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

)

// OperatorKind is a bit field to identify operator types.
type OperatorKind int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint may be better?

@disksing
Copy link
Contributor Author

disksing commented Dec 6, 2017

/run-all-tests

@disksing
Copy link
Contributor Author

disksing commented Dec 6, 2017

/rebuild

@disksing
Copy link
Contributor Author

disksing commented Dec 6, 2017

/run-integration-common-test

@disksing disksing merged commit 5d2c405 into tikv:master Dec 6, 2017
@disksing disksing deleted the operator-kind branch December 6, 2017 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants