Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default commit_ts in tiup-cluster #1116

Open
nexustar opened this issue Jan 5, 2022 · 0 comments
Open

fix default commit_ts in tiup-cluster #1116

nexustar opened this issue Jan 5, 2022 · 0 comments

Comments

@nexustar
Copy link

nexustar commented Jan 5, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.
  • on tiup-cluster before v1.9.x , --initial_commit_ts is set on start script, so it cannot be overwrited be config file.
  • on tiup-cluster before v1.8.1, it has wrong default value "0"
  • we plan to remove it on start script on tiup-cluster v1.9.0(https://github.com/pingcap/tiup/pull/1706/files) and migrate the configure,please help to review and see if we need to fix wrong default value "0" on old cluster.
  1. What did you expect to see?

  2. What did you see instead?

  3. Please provide the relate downstream type and version of drainer.
    (run drainer -V in terminal to get drainer's version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant