Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement Request: Database and Table Level Metrics #545

Closed
breezewish opened this issue May 28, 2020 · 1 comment
Closed

Requirement Request: Database and Table Level Metrics #545

breezewish opened this issue May 28, 2020 · 1 comment

Comments

@breezewish
Copy link
Member

breezewish commented May 28, 2020

Description

Related project: TiDB

Currently TiDB only supports metrics of the whole TiDB cluster or single TiDB instance. Database or table metrics are missing. For critical metrics like QPS, latency, errors, a more detailed, per-table and per-database metrics is needed.

The technical implementation needs to be further investigated. A possible solution can be using Prometheus labels. The corresponding label in memory metrics need to be deleted when table or database is deleted. Notice that there might be a lot of databases and tables and attaching metrics for each one may affect performance, so that it may not be suitable to adapt all metrics. Also histograms and multi-label metrics need to be very carefully considered, since they notably amplify the number of metrics. Another good idea can be allowing users to config what tables and databases are needed.

The new metrics should be added to the Grafana monitor.

Notice that TiDB already have a similar feature: pingcap/tidb#9151 However it may lead to memory leaks due to always keeping database names in the memory, as well as not work well when database numbers are huge. The new implementation could refine and improve it.

Category

  • Feature
  • Usability

Value

Many customers use a single TiDB cluster to serve multiple & hybrid payloads (in different databases). This helps them better identify problems or running status of each payload.

  • Score: 4

Workload Estimation

15 Person Day

@breezewish
Copy link
Member Author

Related: pingcap/tidb#17688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant