Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some useful additional printer columns for TidbMonitor #2169

Closed
cofyc opened this issue Apr 13, 2020 · 9 comments · Fixed by #3958
Closed

Add some useful additional printer columns for TidbMonitor #2169

cofyc opened this issue Apr 13, 2020 · 9 comments · Fixed by #3958
Assignees
Labels
area/monitor monitoring Hacktoberfest status/help-wanted Extra attention is needed
Milestone

Comments

@cofyc
Copy link
Contributor

cofyc commented Apr 13, 2020

Feature Request

Is your feature request related to a problem? Please describe:

Now it uses the default columns.

$ kubectl get tidbmonitor
NAME    AGE
basic   23s

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@cofyc cofyc added the status/help-wanted Extra attention is needed label Jun 8, 2020
@cofyc
Copy link
Contributor Author

cofyc commented Jun 22, 2020

@mikechengwei
in production, what information is useful and should be printed?

@mikechengwei
Copy link
Contributor

mikechengwei commented Jun 22, 2020

TidbMonitor have grafana ,prometheus,reloader and additional container. Do we need to show their status like TidbCluster?

NAME                PD                                              STORAGE   READY   DESIRE   TIKV                                              STORAGE   READY   DESIRE   TIDB   READY   DESIRE

But tidbmonitor is running in a pod with multiple containers, user can describe pod to get information which they want.

@cofyc
Copy link
Contributor Author

cofyc commented Jun 22, 2020

maybe we can show their running status? then we can quickly check if components have problems or not

@mikechengwei
Copy link
Contributor

Do you mean ready and desire info? Tidbmonitor is running in a pod with multiple containers, i think we can't use ready and desire columns. We can use ready column the same as in pod columns.

@mikechengwei
Copy link
Contributor

We can inherit tidbmonitor pod info. READY , STATUS and RESTARTS columns . What do you think?

@cofyc
Copy link
Contributor Author

cofyc commented Jun 22, 2020

I think it will be useful.

@mikechengwei
Copy link
Contributor

Ok, i can do it and do it well soon.

@cofyc
Copy link
Contributor Author

cofyc commented Jun 22, 2020

thanks! for users who do not know technical details, they may check the status TidbMonitor to see if the monitor is ready or not. I guess it will be useful if we can print more information by default.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitor monitoring Hacktoberfest status/help-wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants