Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failover and scaling are blocked if one Pod failed during rolling update #2739

Closed
DanielZhangQD opened this issue Jun 17, 2020 · 2 comments · Fixed by #2886 or #3187
Closed

failover and scaling are blocked if one Pod failed during rolling update #2739

DanielZhangQD opened this issue Jun 17, 2020 · 2 comments · Fixed by #2886 or #3187
Assignees
Labels
priority:P1 status/help-wanted Extra attention is needed
Milestone

Comments

@DanielZhangQD
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

Take TiKV for example, during TiKV rolling update, if one TiKV Pod failed, e.g. something wrong with the node it was running and it cannot be scheduled to any node, then the upgrade will be stuck in waiting this Pod ready and its store UP, however, in this case, if the failover cannot occur because it's blocked by the logic https://github.com/pingcap/tidb-operator/blob/master/pkg/manager/member/tikv_upgrader.go#L110-L115, and if users want to scale out a new TiKV to increase the replicas, it still is impossible due to the same reason.
Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@DanielZhangQD DanielZhangQD added the status/help-wanted Extra attention is needed label Jun 17, 2020
@DanielZhangQD DanielZhangQD added this to the v1.1.2 milestone Jun 17, 2020
@DanielZhangQD
Copy link
Contributor Author

@weekface @cofyc @Yisaer WDYT about this issue?

@DanielZhangQD
Copy link
Contributor Author

DanielZhangQD commented Aug 17, 2020

PD and TiDB should have a similar fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:P1 status/help-wanted Extra attention is needed
Projects
None yet
3 participants