Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackupSchedule: support automatic backup log truncate when only maxBackups is supplied #6068

Open
kennytm opened this issue Feb 10, 2025 · 0 comments

Comments

@kennytm
Copy link

kennytm commented Feb 10, 2025

Feature Request

Is your feature request related to a problem? Please describe:

In a BackupSchedule CR, if logBackupTemplate is setup, it will run log backup. According to the docs, the streaming logs will be truncated only according to maxReservedTime.

Expiry of snapshot backup can be configured with either maxBackups or maxReservedTime. Because the schedule may be irregular, it is not always possible to use maxReservedTime to reproduce the effect of maxBackups.

(internal - see GTOC-7367 for details)

Describe the feature you'd like:

When some snapshots are deleted by maxBackups, additionally use that oldest snapshot's CommitTS has the TruncateTSO and perform br log truncate.

Describe alternatives you've considered:
Keep the status quo? 🤔

Teachability, Documentation, Adoption, Migration Strategy:

In the BackupSchedule CR documentation, change this sentence:

- The log backup is created and deleted along with `backupSchedule` and recycled according to `.spec.maxReservedTime`.
+ The log backup is created and deleted along with `backupSchedule` and recycled according to `.spec.maxReservedTime` or `.spec.maxBackups`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants