Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCP-4: Improve the performance of WindowExec by using multi-thread hash grouping #12966

Closed
SunRunAway opened this issue Oct 28, 2019 · 6 comments
Closed

PCP-4: Improve the performance of WindowExec by using multi-thread hash grouping #12966

SunRunAway opened this issue Oct 28, 2019 · 6 comments
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.

Comments

@SunRunAway
Copy link
Contributor

SunRunAway commented Oct 28, 2019 •
edited by you06
Loading

Description

TiDB implements window function feature compatible with mysql(https://dev.mysql.com/doc/refman/8.0/en/window-functions.html). The performance has much space to improve.

Considering using a multi-thread hash grouping, to run each window partition in parallel.

Goals:

  • Use a multi-thread hash grouping, to run each window partition in parallel.

Difficulty

  • Medium

Score

  • 2100

Mentor(s)

Recommended Skills

  • SQL Optimization
  • Golang Profiling
  • Code Refactoring
@SunRunAway SunRunAway added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution difficulty/medium labels Oct 28, 2019
@jarvys
Copy link
Contributor

jarvys commented Nov 4, 2019

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 4, 2019

@jarvys don't have enough score, pick up failed
Progress 0/400
You may pick up some easy issues first.

@sre-bot sre-bot added the PCP-S1 label Nov 4, 2019
@pingyu
Copy link
Contributor

pingyu commented Dec 5, 2019

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

@pingyu pick up issue success

@SunRunAway
Copy link
Contributor Author

@pingyu Do you have any ideas or plans to do this PCP, we can make a meeting to discuss it.

@pingyu
Copy link
Contributor

pingyu commented Dec 14, 2019

@SunRunAway
That's great !
I am working on it, and writing a document of my plans. Talk to you later~

@pingyu pingyu mentioned this issue Dec 25, 2019
Merged
@sre-bot sre-bot closed this as completed Jan 16, 2020
@SunRunAway SunRunAway mentioned this issue Jan 19, 2020
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SunRunAway @pingyu @jarvys @sre-bot