Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP: Add more specified execution information for executor and record in slow log. #15009

Closed
Tracked by #14974
crazycs520 opened this issue Feb 28, 2020 · 9 comments · Fixed by #17573
Closed
Tracked by #14974

UCP: Add more specified execution information for executor and record in slow log. #15009

crazycs520 opened this issue Feb 28, 2020 · 9 comments · Fixed by #17573
Labels
epic/slow-query sig/execution SIG execution

Comments

@crazycs520
Copy link
Contributor

crazycs520 commented Feb 28, 2020 •
edited
Loading

Description

This is the subtask of issue #14974.

Collection more specified information of executor

Such as HashJoin:

  • time cost of build memory table.
  • time cost of join

Such as IndexLookupReader:

  • time cost of read index.
  • time cost of read rows,
  • the number of the read indexs and rows.
    ...

And we also need to collect execution information for insert/delete/update executor, and get tso time.

Below are some executor list that needs to add specified execution information:

  • TableReaderExecutor
  • IndexLookUpExecutor
  • HashJoinExec
  • IndexLookUpJoin
  • IndexLookUpMergeJoin
  • IndexNestedLoopHashJoin
  • MergeJoinExec
  • NestedLoopApplyExec
    ...

Score

  • 1294

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • SQL Executer
  • SQL Plan

Learning Materials
@crazycs520 crazycs520 mentioned this issue Feb 28, 2020
Open
3 tasks
@crazycs520 crazycs520 changed the title Add more specified execution information for executor and record in slow log. UCP: Add more specified execution information for executor and record in slow log. Feb 28, 2020
@TennyZhuang
Copy link
Contributor

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 19, 2020

@TennyZhuang pick up issue success

@sre-bot sre-bot mentioned this issue Mar 19, 2020
Open
@TennyZhuang
Copy link
Contributor

/give-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 19, 2020

@TennyZhuang give up issue success

@yzwqf
Copy link
Contributor

yzwqf commented Mar 23, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2020

@yzwqf pick up issue success

@sre-bot
Copy link
Contributor

sre-bot commented Apr 6, 2020

This pick has been automatically canceled after more than a week.

@crazycs520
Copy link
Contributor Author

I will do it 😂

@qw4990 qw4990 mentioned this issue Jun 1, 2020
Closed
10 tasks
@crazycs520 crazycs520 mentioned this issue Jun 1, 2020
Merged
@SunRunAway
Copy link
Contributor

SunRunAway commented Jun 15, 2020 •
edited
Loading

@crazycs520 Would you like to add documentation?

@ti-srebot ti-srebot mentioned this issue Jun 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic/slow-query sig/execution SIG execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: record execute runtime information in slow log crazycs520/tidb
6 participants
@SunRunAway @zz-jason @TennyZhuang @crazycs520 @sre-bot @yzwqf