Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP: improve UT coverage of package planner, part 1 #15681

Closed
4 tasks
zz-jason opened this issue Mar 25, 2020 · 7 comments · Fixed by #16093
Closed
4 tasks

UCP: improve UT coverage of package planner, part 1 #15681

zz-jason opened this issue Mar 25, 2020 · 7 comments · Fixed by #16093
Assignees
@hsqlu
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/planner SIG: Planner

Comments

@zz-jason
Copy link
Member

zz-jason commented Mar 25, 2020 •
edited
Loading

Description

As the title said, this task is aimed to improve the unit test coverage of package planner. You can generate the coverage report and view it in browser with the following commands:

cd planner
go test -coverprofile=coverage.out # runs the unit test, writes the coverage profile to coverage.out
go tool cover -html=coverage.out   # displays the coverage report in your browser

The following codes should be covered:

Score

  • 100

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • Basic TiDB SQL Optimization

Learning Materials
@zz-jason zz-jason added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/planner SIG: Planner difficulty/easy labels Mar 25, 2020
@hsqlu
Copy link
Contributor

hsqlu commented Mar 31, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

@hsqlu pick up issue success

@hsqlu
Copy link
Contributor

hsqlu commented Mar 31, 2020

@winoros Hi, I can't get the report for planner/optimize.go on my local, do you know what's the problem?

@sre-bot sre-bot mentioned this issue Apr 1, 2020
Closed
@hsqlu
Copy link
Contributor

hsqlu commented Apr 1, 2020

/give-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2020

@hsqlu give up issue success

@hsqlu hsqlu mentioned this issue Apr 7, 2020
Merged
@hsqlu
Copy link
Contributor

hsqlu commented Apr 7, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

@hsqlu pick up issue success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsqlu hsqlu

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/planner SIG: Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UCP: improve UT coverage of package planner, part 1 hsqlu/tidb
3 participants
@hsqlu @zz-jason @sre-bot