Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to not print arguments in slowlog #17463

Closed
tirsen opened this issue May 28, 2020 · 1 comment · Fixed by #17637
Closed

Flag to not print arguments in slowlog #17463

tirsen opened this issue May 28, 2020 · 1 comment · Fixed by #17637
Assignees
Labels
feature/accepted This feature request is accepted by product managers priority/release-blocker This issue blocks a release. Please solve it ASAP. security Everything related with security type/feature-request Categorizes issue or PR as related to a new feature.
Milestone

Comments

@tirsen
Copy link
Contributor

tirsen commented May 28, 2020

We would like a flag that disables the printing of argument values in the slowlog. Only the query should be printed.

@tirsen tirsen added the type/feature-request Categorizes issue or PR as related to a new feature. label May 28, 2020
@shenli shenli added the security Everything related with security label May 28, 2020
@shenli shenli added this to the v4.0.1 milestone May 31, 2020
@bb7133
Copy link
Member

bb7133 commented Jun 1, 2020

Hi @tirsen , thanks for this request!

We used to have the plan that treats this as part of the Data Masking, however, the latter one is something big.

Now we're going to provide a system variable like `tidb_slow_log_no_arguments' and behave exactly what you described.

This feature will be added in 4.0.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accepted This feature request is accepted by product managers priority/release-blocker This issue blocks a release. Please solve it ASAP. security Everything related with security type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants