-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the Configuration for SimpleLRUCache #17567
Comments
Hi @dbjoa, from the description above, we are going to abandon |
Hi @zz-jason, |
IMO, the memory ratio strategy should be kept (but disabled by default) for compatibility of the upgraded server. |
It's ok for me. |
We should set different memory pool: server memory = plan memory + executor memory + cache memory + schema memory + statistics memory+ others, similar to MySQL, Oracle and others. |
After discuss with @SunRunAway , we decide still remain |
Feature Request
Is your feature request related to a problem? Please describe:
In my view, some configurations for
SimpleLRUCache
is misleading and some are over-designed.For
max-memory
, the description in our document misleads and may let user to thinkmax-memory
is only for managingSimpleLRUCache
memory usage.However, in our config.example.toml,
max-memory
is described as the memory quota for a single tidb-server. And in #16777 , and we also letmax-memory
to control the memory quota as a tidb-server. The difference between the usage and description formax-memory
may make user confusion.#17298 also pointed out this.
Also, as
GlobalLRUMemUsageTracker
introduced in #16777 , I think thememory-guard-ratio
is no longer needed andCapacity
is enough for the elimination strategy.Describe the feature you'd like:
To remove the misleading and unnecessary configuration, I think we can
server-memory-quota
for the memory quota for a single tidb-server. config: Revise SimpleLRUCache Configuration #17532max-memory
after v4.0Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
The text was updated successfully, but these errors were encountered: