Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tidb_enable_collect_execution_info by default? #18937

Closed
breezewish opened this issue Aug 3, 2020 · 4 comments
Closed

Enable tidb_enable_collect_execution_info by default? #18937

breezewish opened this issue Aug 3, 2020 · 4 comments
Labels
feature/accepted This feature request is accepted by product managers type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@breezewish
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe:

This is an issue to discuss whether tidb_enable_collect_execution_info shall be enabled by default.

Describe the feature you'd like:

tidb_enable_collect_execution_info is introduced in #17573 , which can be pretty helpful to see what happens for a slow query.

By enabling it by default, the overall performance affection is 0.2% ~ 3%.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@breezewish breezewish added the type/feature-request Categorizes issue or PR as related to a new feature. label Aug 3, 2020
@zz-jason
Copy link
Member

zz-jason commented Aug 6, 2020

By enabling it by default, the overall performance affection is 0.2% ~ 3%.

It's better to clearly describe the performance impacts for several parts:

  • the benchmark
  • QPS impact
  • CPU impact
  • duration impact
  • log size impact
  • etc.

@zz-jason zz-jason added the feature/accepted This feature request is accepted by product managers label Aug 6, 2020
@breezewish
Copy link
Member Author

@crazycs520 PTAL

@crazycs520
Copy link
Contributor

Great, I will do a bench test later.

@breezewish
Copy link
Member Author

Since this parameter is already enabled by default in v4.0.3, I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/accepted This feature request is accepted by product managers type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@breezewish @zz-jason @crazycs520