Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn:make amended transaction semantic compatible #21069

Closed
cfzjywxk opened this issue Nov 16, 2020 · 1 comment
Closed

txn:make amended transaction semantic compatible #21069

cfzjywxk opened this issue Nov 16, 2020 · 1 comment
Labels
sig/transaction SIG:Transaction type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@cfzjywxk
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

The transaction amend may indrocude some incompatilities, we need to solve these issues for specific amend type.

Issues like:

  • Amend transaction can cause lost update #20912. For add column amend type, since the newest value on the added column will not be recorded in the amended transaction memory buffer, the amend will overwrite the newest written data, which causes lost update.

Describe the feature you'd like:

Make the amended transaction semantic compatible.

Describe alternatives you've considered:

We need to consider if memory buffer amend is needed under certain circumstances. Also, we need to evaluate the risk and benefit.

Teachability, Documentation, Adoption, Migration Strategy:

Check the amend project and sig-transaction for more information.

@cfzjywxk cfzjywxk added sig/transaction SIG:Transaction type/feature-request Categorizes issue or PR as related to a new feature. labels Nov 16, 2020
@Defined2014
Copy link
Contributor

The amend txn is deprecated in v6.5.0. There should be no any progress on this issue, so close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants