Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter region when creating tables is not work #22788

Closed
jackysp opened this issue Feb 18, 2021 · 4 comments
Closed

Scatter region when creating tables is not work #22788

jackysp opened this issue Feb 18, 2021 · 4 comments
Assignees
Labels
component/pd severity/major type/bug The issue is confirmed as a bug.

Comments

@jackysp
Copy link
Member

jackysp commented Feb 18, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. set global tidb_scatter_region = 1;
  2. create table without pre-split option in a new session.
  3. grep logs of pd leader to find 'add operator' and then 'mv light peer'.

2. What did you expect to see? (Required)

Get the operator log.

3. What did you see instead (Required)

No this operator log.

4. What is your TiDB version? (Required)

c9af430

@jackysp jackysp added the type/bug The issue is confirmed as a bug. label Feb 18, 2021
@jackysp
Copy link
Member Author

jackysp commented Feb 18, 2021

This pr #20980 introduced it. It used the batch API ScatterRegions instead of ScatterRegion, but the batched API doesn't have the same behavior as the single API except it will scatter multi-regions. It is not easy to use the single API directly, because pd doesn't have a single API with an option, which is introduced in #19844 . #19844 is an optimization that could not be reverted directly.
PTAL @Yisaer @JmPotato

@wjhuang2016
Copy link
Member

It seems that the basic test is missing.

@nolouch
Copy link
Member

nolouch commented Dec 13, 2021

fixed.

@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/pd severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

5 participants