-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: ddl job will hang on loop when it encounts panic in cancelling logic #23202
Labels
Comments
Please edit this comment or add a new comment to complete the following informationNot a bug
Duplicate bug
BugNote: Make Sure that 'component', and 'severity' labels are added 1. Root Cause Analysis (RCA) (optional)2. Symptom (optional)3. All Trigger Conditions (optional)4. Workaround (optional)5. Affected versions[v4.0.0:v4.0.11],[v5.0.0-rc] 6. Fixed versionsmaster |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
The case is that when add index takes a long time, the user manually canceled the DDL job, so the add index logic will be converted to drop index logic.
Once there is a panic in the path of canceling, the goroutine will be pulled up and set its state as canceling again, which is a dead loop.
We should count the error count when the goroutine being pulled up from a panic.
Reproduce step:
2. What did you expect to see? (Required)
it can break the loop when it has been pulled up from panic for 512 times.
3. What did you see instead (Required)
dead loop
4. What is your TiDB version? (Required)
master, 5.0, 4.0 ....
The text was updated successfully, but these errors were encountered: