Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the value of tikv-client.store-liveness-timeout should not less than 0 #24109

Closed
seiya-annie opened this issue Apr 19, 2021 · 2 comments · Fixed by #24244
Closed

the value of tikv-client.store-liveness-timeout should not less than 0 #24109

seiya-annie opened this issue Apr 19, 2021 · 2 comments · Fixed by #24244
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.

Comments

@seiya-annie
Copy link

seiya-annie commented Apr 19, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

param: tikv-client.store-liveness-timeout: "1s"
the value of this config should : >=0.
store-liveness-timeout =0, means close the function of check tikv status port.

2. What did you expect to see? (Required)

if set store-liveness-timeout = -1, report error in log.

3. What did you see instead (Required)

set successfully, and no error

4. What is your TiDB version? (Required)

v5.0.0

@seiya-annie seiya-annie added type/bug The issue is confirmed as a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor labels Apr 19, 2021
@Howie59
Copy link
Contributor

Howie59 commented Apr 19, 2021

/assign

@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants