Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index related case got data race #25043

Closed
guo-shaoge opened this issue Jun 2, 2021 · 1 comment
Closed

index related case got data race #25043

guo-shaoge opened this issue Jun 2, 2021 · 1 comment
Labels
severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@guo-shaoge
Copy link
Collaborator

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Found by CI unit-test.

2. What did you expect to see? (Required)

Everything be ok.

3. What did you see instead (Required)

[2021-06-02T02:12:38.189Z] WARNING: DATA RACE
[2021-06-02T02:12:38.189Z] Write at 0x00c0002e8570 by goroutine 401:
[2021-06-02T02:12:38.189Z]   runtime.mapassign_fast64()
[2021-06-02T02:12:38.189Z]       /usr/local/go/src/runtime/map_fast64.go:92 +0x0
[2021-06-02T02:12:38.189Z]   github.com/pingcap/parser/terror.ErrClass.initError()
[2021-06-02T02:12:38.190Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210525032559-c37778aff307/terror/terror.go:156 +0xd6
[2021-06-02T02:12:38.190Z]   github.com/pingcap/parser/terror.ErrClass.NewStdErr()
[2021-06-02T02:12:38.190Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210525032559-c37778aff307/terror/terror.go:179 +0x4c
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/ddl.buildTableInfo()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:1399 +0x22be
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/ddl.buildTableInfoWithStmt()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:1732 +0x452
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/ddl.(*ddl).CreateTable()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:1812 +0x566
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/executor.(*DDLExec).executeCreateTable()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/ddl.go:205 +0xf6
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/executor.(*DDLExec).Next()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/ddl.go:93 +0x796
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/executor.Next()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor.go:284 +0x2a8
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:565 +0x3bc
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:446 +0x276
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:395 +0x67a
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/session.runStmt()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1637 +0x323
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/session.(*session).ExecuteStmt()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1532 +0xbf0
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).Exec()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:170 +0x2fc
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).ExecToErr()
[2021-06-02T02:12:38.190Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:356 +0x96
[2021-06-02T02:12:38.190Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).MustGetErrMsg()
[2021-06-02T02:12:38.191Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:365 +0x84
[2021-06-02T02:12:38.191Z]   github.com/pingcap/tidb/session_test.(*testClusteredSuite).TestClusteredIndexSyntax()
[2021-06-02T02:12:38.191Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/clustered_index_test.go:561 +0x626
[2021-06-02T02:12:38.191Z]   runtime.call16()
[2021-06-02T02:12:38.191Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-06-02T02:12:38.191Z]   reflect.Value.Call()
[2021-06-02T02:12:38.191Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-06-02T02:12:38.191Z] 
[2021-06-02T02:12:38.191Z] Previous read at 0x00c0002e8570 by goroutine 405:
[2021-06-02T02:12:38.191Z]   runtime.mapaccess2_fast64()
[2021-06-02T02:12:38.191Z]       /usr/local/go/src/runtime/map_fast64.go:52 +0x0
[2021-06-02T02:12:38.191Z]   github.com/pingcap/parser/terror.getMySQLErrorCode()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210525032559-c37778aff307/terror/terror.go:224 +0x20e
[2021-06-02T02:12:38.191Z]   github.com/pingcap/parser/terror.ToSQLError()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210525032559-c37778aff307/terror/terror.go:202 +0x55
[2021-06-02T02:12:38.191Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).MustGetErrCode()
[2021-06-02T02:12:38.191Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:377 +0x3c4
[2021-06-02T02:12:38.191Z]   github.com/pingcap/tidb/session_test.(*testSessionSuite3).TestIndexMaxLength.func2()
[2021-06-02T02:12:38.191Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session_test.go:1567 +0x110
[2021-06-02T02:12:38.191Z]   github.com/pingcap/tidb/session_test.(*testSessionSuite3).TestIndexMaxLength()
[2021-06-02T02:12:38.191Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session_test.go:1576 +0x859
[2021-06-02T02:12:38.191Z]   runtime.call16()
[2021-06-02T02:12:38.191Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-06-02T02:12:38.191Z]   reflect.Value.Call()
[2021-06-02T02:12:38.191Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-06-02T02:12:38.191Z] 
[2021-06-02T02:12:38.191Z] Goroutine 401 (running) created at:
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).asyncRun.func1()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:650 +0x105
[2021-06-02T02:12:38.191Z] 
[2021-06-02T02:12:38.191Z] Goroutine 405 (running) created at:
[2021-06-02T02:12:38.191Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-06-02T02:12:38.191Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
[2021-06-02T02:12:38.191Z] [2021/06/02 10:12:37.925 +08:00] [INFO] [session.go:2754] ["CRUCIAL OPERATION"] [conn=62] [schemaVersion=125] [cur_db=test_index_max_length] [sql="create table t (a blob(10000), b integer, index idx(a(3068), b))"] [user=]
[2021-06-02T02:12:38.192Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-06-02T02:12:38.192Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
[2021-06-02T02:12:38.192Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-06-02T02:12:38.192Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
[2021-06-02T02:12:38.192Z]   github.com/pingcap/check.(*suiteRunner).asyncRun.func1()
[2021-06-02T02:12:38.192Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:650 +0x105

4. What is your TiDB version? (Required)

master
@guo-shaoge guo-shaoge added the type/bug The issue is confirmed as a bug. label Jun 2, 2021
@ichn-hu ichn-hu mentioned this issue Jun 3, 2021
Closed
@eurekaka eurekaka added sig/sql-infra SIG: SQL Infra and removed sig/planner SIG: Planner labels Jun 7, 2021
@xiongjiwei
Copy link
Contributor

seems fixed by #25405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eurekaka @guo-shaoge @aytrack @xiongjiwei